Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate the facet distribution and facet stats in our own objects #60

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

loevgaard
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 33.04%. Comparing base (adc4885) to head (7c151d9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Engine/FacetValues.php 0.00% 30 Missing ⚠️
src/Engine/FacetDistribution.php 0.00% 24 Missing ⚠️
src/Engine/FacetStats.php 0.00% 24 Missing ⚠️
src/Engine/FacetStat.php 0.00% 7 Missing ⚠️
src/Form/Builder/ChoiceFilterFormBuilder.php 0.00% 7 Missing ⚠️
src/Form/Builder/RangeFilterFormBuilder.php 0.00% 3 Missing ⚠️
src/Engine/SearchResult.php 0.00% 2 Missing ⚠️
src/Form/Builder/CheckboxFilterFormBuilder.php 0.00% 2 Missing ⚠️
src/Form/Builder/CompositeFilterFormBuilder.php 0.00% 2 Missing ⚠️
src/Form/Builder/SearchFormBuilder.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     34.26%   33.04%   -1.23%     
- Complexity      620      660      +40     
============================================
  Files           120      124       +4     
  Lines          2104     2182      +78     
============================================
  Hits            721      721              
- Misses         1383     1461      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard force-pushed the encapsulate-facets branch 3 times, most recently from 5fbc2e3 to 73501b9 Compare February 13, 2025 22:14
@loevgaard loevgaard merged commit 265d467 into master Feb 14, 2025
31 of 38 checks passed
@loevgaard loevgaard deleted the encapsulate-facets branch February 14, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant